Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: 環境変数を Envs クラスで型付け #1402

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 16, 2024

内容

環境変数を Envs クラスで一括管理してバリデーション・型付けするリファクタリングを提案します。

関連 Issue

part of #1404

@tarepan tarepan requested a review from a team as a code owner June 16, 2024 06:11
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 16, 2024 06:11
@tarepan tarepan marked this pull request as draft June 18, 2024 10:22
@tarepan tarepan marked this pull request as ready for review June 19, 2024 03:08
@tarepan
Copy link
Contributor Author

tarepan commented Jun 19, 2024

#1404 の Go 判断に基づき、draft を解除しました。レビューよろしくお願いします。

@tarepan tarepan changed the title 整理: 環境変数をクラス化して型付け 整理: 環境変数を Envs クラスで型付け Jun 19, 2024
run.py Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 6ce5930 into VOICEVOX:master Jun 20, 2024
4 checks passed
@tarepan tarepan deleted the refactor/run_env_vars branch June 21, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants