-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: Label
context 個別属性のアクセッサ
#971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
一気に読みやすくなりましたね!!
def mora_idx(self) -> int: | ||
"""アクセント句内におけるモーラのインデックス (1 ~ 49)""" | ||
return int(self.contexts["a2"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indexかidxどちらが良いか、既存コードをサーチした感じ、indexが多数でした。
こちらに変えさせていただきます!
index https://github.com/search?q=repo%3AVOICEVOX%2Fvoicevox_engine%20index&type=code
idx https://github.com/search?q=repo%3AVOICEVOX%2Fvoicevox_engine%20idx&type=code
内容
Label
context 個別属性のアクセッサ追加によるリファクタリング関連 Issue
ref #970 (comment)