Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cors_policy_mode, allow_originの優先度についてhelpオプションに追加 #985

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

tomoish
Copy link
Contributor

@tomoish tomoish commented Jan 7, 2024

内容

run.pyのhelpオプションにcors_policy_mode, allow_originが実行時引数と設定ファイルのどちらを優先するかを明記

関連 Issue

ref #963

@tomoish tomoish requested a review from a team as a code owner January 7, 2024 06:40
@tomoish tomoish requested review from y-chan and removed request for a team January 7, 2024 06:40
@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for y-chan January 7, 2024 08:27
@Hiroshiba
Copy link
Member

Hiroshiba commented Jan 7, 2024

プルリクエストありがとうございます!!
良さそうな説明に感じました!!

2コミット目でREADMEのスペースを消されてますが、これは最後にスペースを2つ置くと改行になるというmarkdownの記法です。
読みづらくなっちゃうので戻していただけると・・・!
(たぶんgit revert bf3a98eとかで戻るはず?)

@tomoish
Copy link
Contributor Author

tomoish commented Jan 7, 2024

@Hiroshiba さん
レビューありがとうございます。
READMEの空白の件、修正いたしました。
よろしくお願いいたします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

大変お待たせしました、プルリクエストありがとうございました!!

@Hiroshiba Hiroshiba merged commit 896bc3e into VOICEVOX:master Jan 8, 2024
3 checks passed
Copy link

github-actions bot commented Jan 8, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 516 330 coverage-36%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 94 72 coverage-23%
voicevox_engine/core_adapter.py 51 17 coverage-67%
voicevox_engine/core_initializer.py 59 30 coverage-49%
voicevox_engine/core_wrapper.py 224 159 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 36 8 coverage-78%
voicevox_engine/dev/tts_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 27 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 92 5 coverage-95%
voicevox_engine/metas/Metas.py 34 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 17 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 27 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_list.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 195 8 coverage-96%
voicevox_engine/user_dict.py 145 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2294 728 coverage-68%

@tomoish tomoish deleted the update-run-help branch February 16, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants