-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYP: numpyの型情報を追加 #988
Merged
Merged
TYP: numpyの型情報を追加 #988
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e860931
TYP: numpyの型情報を追加
sabonerune 28480d2
FIX: mock修正
sabonerune 8912b04
npt.NDArray -> NDArray
Hiroshiba 53104c2
integer -> int64
Hiroshiba ea72eb8
np.floatingをいくつか排除
Hiroshiba 2b6f3ea
Apply suggestions from code review
Hiroshiba 5f7f349
要らなくなったはずのgenericsの撤去
Hiroshiba 85af577
Merge branch 'typ/numpy-type' of github.com:sabonerune/voicevox_engin…
Hiroshiba 4bd562c
lintミス
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
エンジンの型と合わないため動作を変えました。
エンジンでは
npt.NDArray[np.float32]
かnpt.NDArray[np.float64]
を返すはず。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ちょっと自信ないのですが、値域が違うかもです!
float32のwavは-1から1、int16は…ちょっとわかりませんが、そのあたり変換しないとすごい音量になるかもです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうですね。
soundfileが自動的に識別して処理していたことを忘れていました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
変更した理由
戻り値のdtypeが
np.integer
やnp.int16
だとmypyが通らない。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!
たぶんfloatにした後2の15乗くらいで割ればいい感じになる気がします!(自信若干なし)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今思いついたのですがtts_engineの型情報の方を緩めればいいことに気づきました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
普通はmock側を実体に合わせるので、mockに合わせて型変えるのはちょっと逆かもです!