Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring "Agents" directory #132

Closed
jhaack opened this issue Jul 29, 2015 · 2 comments
Closed

Refactoring "Agents" directory #132

jhaack opened this issue Jul 29, 2015 · 2 comments
Assignees
Milestone

Comments

@jhaack
Copy link
Contributor

jhaack commented Jul 29, 2015

Currently all agents live under the Agents directory off the base of the project. This can cause confusion as to what agents are essential to the platform, what are applications, and what are meant as examples. A new structure should be selected.

Proposal:

volttron/Agents goes away and is replaced with

volttron/

        services/    -> Agents which provide services to other agents.
                       core/  -> The core set of services for running the platform
                       contrib/  -> Services contributed back to the community, may be integrated into core

        applications/
                           examples/ -> Simple applications meant to illustrate a single feature
                           <organization name> -> Applications contributed by an organization
                           contrib/      -> General directory for other agents contributed back

The applications directory could potentially be a separate repository.

@ahjortland
Copy link

I think this is a good idea - previously I have been confused about the origins and purposes of some agents.

Along these lines, would it also make sense to require/recommend a README in the base directory of each agent describing the origin, purpose, some implementation details, how it works, additional package requirement, etc.? While some of this information can probably be inferred from the source, it might be more convenient to put important info in a central place.

@jhaack
Copy link
Contributor Author

jhaack commented Jul 30, 2015

A README would be very good. Some agents have content in the wiki but having it along with the agent makes sense too. In that README should be what version of the platform the agent has been verified with. This would clarify cases where agents were contributed back in a previous version but have not been checked by the authors against a newer version.

@craig8 craig8 self-assigned this Jul 31, 2015
@craig8 craig8 mentioned this issue Aug 6, 2015
jhaack added a commit that referenced this issue Aug 6, 2015
@craig8 craig8 added this to the 3.0b2 milestone Aug 25, 2015
@craig8 craig8 closed this as completed Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants