Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Single Machine install tags and fake driver #2786

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Fix Single Machine install tags and fake driver #2786

merged 3 commits into from
Sep 22, 2021

Conversation

eljpsm
Copy link

@eljpsm eljpsm commented Sep 13, 2021

  • Fix tag naming so that SQLHistorian is tagged platform_historian and
    ListenerAgent is tagged listener.
  • Change note under section Install a Fake Driver so that it explicitly
    states the assumption that the user is currently in the volttron root
    directory like the previous section.
  • Change following commands to reflect change in note.
  • Fix final command in code-block to both point to the correct directory
    and load the csv file correctly.

Signed-off-by: Elijah J. Passmore elijah@elijahjpassmore.com

Description

A few small changes to the documentation section Single Machine under Deploying VOLTTRON. There are a few errors in tag naming, inconsistency in assumptions present in the section Install Agents and Historian compared to Install a Fake Driver, and finally incorrect code-block commands.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

I built the website and did manual testing to make sure that it looked correct.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- Fix tag naming so that SQLHistorian is tagged platform_historian and
  ListenerAgent is tagged listener.
- Change note under section Install a Fake Driver so that it explicitly
  states the assumption that the user is currently in the volttron root
  directory like the previous section.
- Change following commands to reflect change in note.
- Fix final command in code-block to both point to the correct directory
  and load the csv file correctly.

Signed-off-by: Elijah J. Passmore <elijah@elijahjpassmore.com>
Fix an unhandled error that arises from an identity that is currently
not in the user's environment variables being popped.

Signed-off-by: Elijah J. Passmore <elijah@elijahjpassmore.com>
@craig8
Copy link
Contributor

craig8 commented Sep 13, 2021

@elijahjpassmore have you signed the eclipse committers agreement?

@eljpsm
Copy link
Author

eljpsm commented Sep 13, 2021

@craig8 Sorry about that - yes, I have signed the agreement.

@craig8 craig8 merged commit 3e5c55b into VOLTTRON:develop Sep 22, 2021
lazlop pushed a commit to lazlop/volttron that referenced this pull request Jan 4, 2022
Fix Single Machine install tags and fake driver
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants