-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to new rabbitmq server and pika #2839
Conversation
using tls1.3 as default tls version.
@schandrika Can you test this? |
…to shwethanidd-new_pika
@@ -1008,6 +1007,7 @@ def connect_callback(): | |||
binding['routing_key'] == router_key: | |||
router_connected = True | |||
break | |||
router_connected = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier we set router_connected=True only if there are bindings. but it is outside of "if bindings:" so wont the flag get set even if there was attribute error earlier?
no_ack=True) | ||
channel.basic_consume(self._rpc_handler_queue, | ||
self.rpc_message_handler | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you remove no_ack=True, do you require a channel.basic_ack(method.delivery_tag) like the one you added in rmq_pubsub.py ?
test_federation.py fails with gevent error 2021-12-20 16:39:05,653 pika.callback ERROR: Calling <bound method RMQConnection.on_open_error of <volttron.platform.vip.rmq_connection.RMQConnection object at 0x7f394f9b5b80>> for "0:_on_connection_error" failed |
… whl file in dst directory. Sometimes dist directory contains the dir that was zipped.
minor changes for erlang version and wheel generations
update erlang install to use erlang-solutions repo
All basic operations from command line work for rmq single instance. Test cases and multiplatform use cases still need fixing. All vctl-command tests fail though vctl command work fine from command line. Merging this into develop so that we have a newer version of rabbitmq, pika, and cryptography version in develop branch for other agents use. Will create a new issue to open issues related to new pika and rabbitmq |
Created Issue #2864 |
Description
Pika 1.2.0 now supports GeventAdapter natively. With this we can use latest version of rabbitmq (3.9.7) and update supporting packages such as cryptography. This PR covers pika, rabbitmq and crypto updates.
Fixes #2703