Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenADRVEN agent #2859

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Conversation

bonicim
Copy link
Collaborator

@bonicim bonicim commented Jan 27, 2022

Description

  • Adds OpenADRVEN agent to 'services' folder including unit test
  • Adds pytest-asyncio and pytest-timeout to 'testing' requirements
  • Updates ReadTheDocs with OpenADRVEN documentation

Screenshot of ReadTheDocs:

Screen Shot 2022-01-27 at 3 54 00 PM

Screen Shot 2022-01-27 at 3 54 14 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I installed this agent on Volttron platform running the 'develop' branch, using a configuration that connected to our test IPKeys VTN. I verified that the agent can receive events from the VTN.

Unit tests:

➜ pytest      
===================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.8.2, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /Users/boni407/Workplace/volttron-project/volttron/env/bin/python
cachedir: .pytest_cache
rootdir: /Users/boni407/Workplace/volttron-project/volttron, configfile: pytest.ini
plugins: asyncio-0.17.2, timeout-1.4.2
asyncio: mode=auto
collected 1 item                                                                                                                                                                               

test_openadr_ven_agent.py::test_handle_event_should_return_optIn PASSED                                                                                                                  [100%]

======================================================================================= warnings summary =======================================================================================

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@craig8 craig8 deleted the branch VOLTTRON:develop January 29, 2022 03:19
@craig8 craig8 closed this Jan 29, 2022
@bonicim
Copy link
Collaborator Author

bonicim commented Jan 31, 2022

@craig8 Why was this PR closed? Are we no longer adding the OpenADRVEN agent to Volttron 8.2/monolith Volttron?

@craig8
Copy link
Contributor

craig8 commented Feb 1, 2022

@bonicim this happened when I accidentally deleted the develop branch. I quickly rectified that, but this was deleted because of that. see right before it was closed...

@craig8 craig8 reopened this Feb 1, 2022
pytest.ini Show resolved Hide resolved
services/core/OpenADRVenAgent/openadr_ven/agent.py Outdated Show resolved Hide resolved
@craig8
Copy link
Contributor

craig8 commented Feb 2, 2022

@bonicim Can you add the trove classifiers here as well? I think that's the only difference between the two code bases? Well that and the github actions which we don't want here.

@bonicim
Copy link
Collaborator Author

bonicim commented Feb 2, 2022

@bonicim Can you add the trove classifiers here as well? I think that's the only difference between the two code bases? Well that and the github actions which we don't want here.

@craig8 Regarding github actions, are you suggesting to add a Workflow to run OpenADRVenAgent tests in this repo?

@craig8
Copy link
Contributor

craig8 commented Feb 3, 2022

@bonicim I am suggesting that the github action from VOLTTRON/volttron-core should trigger VOLTTRON/volttron-openadr-ven tests.

And this probably isn't the place for that now that I think about it.

@craig8 craig8 merged commit db45473 into VOLTTRON:develop Feb 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants