New Auth Implementation #2926
Merged
New Auth Implementation #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_auth_volttron
…on_auth_volttron # Conflicts: # volttron/platform/auth.py # volttron/platform/main.py Resolved
Updgrade Non-Auth VOLTTRON to 8.1.1
…lttron into non_auth_volttron
…isplay and not Agent instance. Disabled auth subsystem in volttron agent.
…lttron into non_auth_volttron Keeping main the same for now to avoid conflicts with multi-router.
TODO: Finish re-implementation of zap loop. TODO: Update RMQ backwards compatibility with ZMQ through ZMQAuthorization TODO: Rename auth_protocols TODO: Read auth_enabled/version from config file correctly.
Added dataclasses for parameters. Moved and restructured code to break out rmq and zmq, and provide standardized APIs where applicable.
sgilbride
requested review from
craig8,
schandrika and
shwethanidd
and removed request for
schandrika
craig8
reviewed
Mar 23, 2022
volttron/platform/auth/__init__.py
Outdated
| # PACIFIC NORTHWEST NATIONAL LABORATORY operated by | ||
| # BATTELLE for the UNITED STATES DEPARTMENT OF ENERGY | ||
| # under Contract DE-AC05-76RL01830 | ||
| # }}} |
There was a problem hiding this comment.
Consider adding
# Only include things we want
___all__ = ["AuthEntry"]
# Don't expose where the "Real" class is located.
from volttron.platform.auth.auth_entry import AuthEntry
For all of these items.
added 4 commits
March 23, 2022 13:23
Updated terminology in main/config. Updated allow auth to be True by default. Cleaned up some imports.
Added handling for allow_auth and AUTH_ENABLED to manage use of auth in config file. Minor code cleanup.
Rmq non auth
Modified is_running_in_container to handle subprocess error in call.
Fixed web authentication page for RMQ. Fixed CSR handling.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Added grequests. Updated connection_params for build_remote_connection_params. Fixed url_address missing from RMQConnectionAPI.
| if cert_dir: | ||
| # remote cert file for agents will be in agent-data/remote-certs dir | ||
| certfile = os.path.join(cert_dir, os.path.basename(certfile)) | ||
| _log.info("build_remote_connection_param: {}".format(certfile)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| destination_serverkey = serverkey | ||
|
|
||
| _log.debug( | ||
| "Connecting using: %s", get_fq_identity(self.identity) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
federation/shovel fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are the initial steps for decoupling auth features from the VOLTTRON platform. This would allow auth to be used when required, and remove the authentication/authorization layers from instances where they are not required.
In addition, auth is restructured to develop authorization and authentication base classes, with standardized APIs. This will help with future efforts to provide fully modular auth packages for specific message busses or use cases.
Type of change
How Has This Been Tested?
Testing is in progress
Checklist: