Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for tests run on Docker before 9.0 release. #3122

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

davidraker
Copy link
Contributor

@davidraker davidraker commented Oct 2, 2023

Description

Updates made during testing of 9.0 release on volttron-docker. Changes include:

  • Updated version and added requirements entry (openleadr) for OpenADR.
  • Fixed relative file path issue in test for OpenADR
  • Backported demo-board test and XFailed battery_meter test for ModbusTK.
  • Made XFails specific to the relevant parameterizations for control tests.
  • Made rabbit imports conditional in tests for multi-platform and instance setup.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

All unit and integration tests were run, and these changes were made to fix tests which were not passing.

@schandrika schandrika self-requested a review October 11, 2023 22:53
Copy link
Contributor

@schandrika schandrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_battery_meter.py could skip the test cases if IP is not set (similar to test_driver_demo_board.py). I don't have access to run modbus tk integration tests. Rest of the changes look good and tests pass on my environment

@davidraker
Copy link
Contributor Author

test_battery_meter.py could skip the test cases if IP is not set (similar to test_driver_demo_board.py). I don't have access to run modbus tk integration tests. Rest of the changes look good and tests pass on my environment

This is not a remote test. The IP used is a localhost one, so that won't actually be the case. I believe this should be left as XFail.

@shwethanidd shwethanidd merged commit db1275a into VOLTTRON:develop Oct 12, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants