Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate point names #3184

Merged

Conversation

davidraker
Copy link
Contributor

Description

Provides better handling of case where there are missing or duplicate registry entries both for driver, when it is loading configurations, and in the web API when it is building a TopicTree from the driver configurations.

Fixes # (issue)
#3183

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Started driver with test configurations which are missing registry entries and which have duplicated point names. Observed that correct warnings appeared in log. Navigated through vui/platforms/.../devices endpoints in browser. Found correct devices and points without errors. Confirmed that log receives notice of duplicate points when building TopicTree.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

craig8 and others added 3 commits May 10, 2024 10:14
* Update readthedocs requirements.txt

* Update conf.py

* Update requirements_demo.txt

Add missing pandas requirement for demo

* work around for issue VOLTTRON#3154

* Fix for security issue VOLTTRON#3168 (VOLTTRON#3169)

* Fix for security issue VOLTTRON#3168

* handling clean up errors in test

* testing group commands in different test module

* moved group and role test to different module

* moved group and role test to different module

* Added a cache for agent names since platform start

* Fixes process overload from file events

* fixed issue with variable definition.

* Remove PersistentDict from web-user.json file.

* Update admin_endpoints.py

Handle behavior of removing PersistentDict

* Update version to 9.0.1

---------

Co-authored-by: Chandrika Sivaramakrishnan <chandrika@pnnl.gov>
Co-authored-by: Chandrika <schandrika@users.noreply.github.com>
Co-authored-by: Andrew Rodgers <andrew@aceiotsolutions.com>
@davidraker davidraker changed the base branch from develop to releases/9.0.1 May 20, 2024 21:08
@craig8 craig8 merged commit 9205f03 into VOLTTRON:releases/9.0.1 May 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants