You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from HttpWrapper defining various virtual functions in exactly the same way in headers.
While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both OrsWrapper and OsrmRoutedWrapper. So we should move the "default" implementations to HttpWrapper and only override for ValhallaWrapper.
The text was updated successfully, but these errors were encountered:
The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from
HttpWrapper
defining various virtual functions in exactly the same way in headers.While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both
OrsWrapper
andOsrmRoutedWrapper
. So we should move the "default" implementations toHttpWrapper
and only override forValhallaWrapper
.The text was updated successfully, but these errors were encountered: