Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code duplication in routing logic #1184

Closed
jcoupey opened this issue Nov 7, 2024 · 0 comments · Fixed by #1185
Closed

Code duplication in routing logic #1184

jcoupey opened this issue Nov 7, 2024 · 0 comments · Fixed by #1185

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 7, 2024

The sonarcloud checks at #1137 report some code duplication in the routing logic. It is related to various routing wrappers inheriting from HttpWrapper defining various virtual functions in exactly the same way in headers.

While I don't really see how this could be avoided in general, it turns out that here the actual implementation is identical in many cases for both OrsWrapper and OsrmRoutedWrapper. So we should move the "default" implementations to HttpWrapper and only override for ValhallaWrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant