Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code dedup in routing wrappers #1185

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Nov 7, 2024

Issue

Fixes #1184

Tasks

  • Add default (common ORS and OSRM) implementations to HttpWrapper
  • Remove unnecessary overrides in ORS and OSRM wrappers
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.15.0 milestone Nov 7, 2024
@jcoupey jcoupey merged commit 60decd5 into master Nov 7, 2024
3 checks passed
@jcoupey jcoupey deleted the refactor/routing-code-deduplication branch November 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code duplication in routing logic
1 participant