Try out sonarcloud static analysis

[jcoupey]

In addition to #911 and #916, I setup a sonarcloud analysis (free for OSS projects). The result should be public at https://sonarcloud.io/summary/overall?id=VROOM-Project_vroom.

The analysis lists 4 "bugs" and quite a number of code smells. Not sure how we can actually configure the rules used there. Would be obviously very time-consuming to go through all of theses but we can probably look at a few category of suggestion types.

[jcoupey]

This is helpful. Out of the 4 bug reports:

• 2 were related to dead code after #endif with specific compile flags (not critical but cleaner now);
• 1 was a false positive I reported;
• 1 was about using a non-initialized variable.

That last one is interesting: the initialized variable was set during a raw loop right after definition. Because of the internals of the algorithm, it is expected that the value must be set before reaching the end of the loop. Now to silence the warning I replaced that raw loop with a find_if which is both simpler and more expressive, plus we now have an assert in place to check that everything is as expected.