You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I did a lot of refactoring based on the code smell reports. There are probably remaining reports that could be easily fixed and I'll probably do that along the way with other PR. For now the most important remaining reports category are:
Control flow statements nesting
Use std::format instead of manual concatenations
Cognitive complexity of functions
I don't want to address 1. and 3. right now because they would require deeper changes. Maybe those are the right places to use the improve-as-you-code approach targeted with the "new code" score.
I'd like to handle 2. but sadly support for format is not available in gcc 11 which is our current reference version on CI.
Now that the workflow is in place after #984 and the most severe reports are fixed, there are different follow-up tasks here:
The text was updated successfully, but these errors were encountered: