Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No appimage builds since 1.92 #2003

Closed
ppp7032 opened this issue Aug 22, 2024 · 8 comments · Fixed by #2095
Closed

No appimage builds since 1.92 #2003

ppp7032 opened this issue Aug 22, 2024 · 8 comments · Fixed by #2095
Labels
bug Something isn't working

Comments

@ppp7032
Copy link

ppp7032 commented Aug 22, 2024

Describe the bug
No appimage builds provided in github releases.

Please confirm that this problem is VSCodium-specific

  • [*] This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to download appimage from releases.
  2. See there is no appimage build.

Expected behavior
There is an appimage build available in github releases.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
appimages may not be important to most, but in some situations it is the only way to get an app working on a platform.

@ppp7032 ppp7032 added the bug Something isn't working label Aug 22, 2024
@Zamony
Copy link

Zamony commented Sep 2, 2024

Appimage build was probably disabled in commit 41b1e88

@ppp7032
Copy link
Author

ppp7032 commented Sep 4, 2024

Appimage build was probably disabled in commit 41b1e88

So a conscious decision was made by the project to remove support for appimage?

@daiyam
Copy link
Member

daiyam commented Sep 4, 2024

So a conscious decision was made by the project to remove support for appimage?

No, since it's available in the Insiders version (https://github.com/VSCodium/vscodium-insiders/releases/tag/1.93.0.24242-insider)
While there is an error when building 1.92 (https://github.com/VSCodium/vscodium/actions/runs/10674103243/job/29584298631#step:9:1342, runned yesterday)

@ppp7032
Copy link
Author

ppp7032 commented Sep 18, 2024

I noticed AppImages are back in 1.93.1.24256 so I'm closing this issue.

@ppp7032 ppp7032 closed this as completed Sep 18, 2024
@lemonzest79
Copy link

No AppImage build again, last two releases not included, last build with an AppImage was https://github.com/VSCodium/vscodium/releases/tag/1.93.1.24256 could this be fixed please??

@daiyam
Copy link
Member

daiyam commented Oct 8, 2024

I ran again into an error: https://github.com/VSCodium/vscodium/actions/runs/11219168014/job/31185291778

It's a recurrent issue with pkg2appimage since we can't specify a version of the packager.
The error is due to that it has determined that /__w/vscodium/vscodium/build/linux/appimage/VSCodium/VSCodium.AppDir/usr/share/codium/resources/app/node_modules/rc/index.js is of architecture armhf??? It's a javascript file...
So it's require an extra config ARCH=x86_64 because it can't detect correctly a js file as non-binary.
It might get fixed with the next release of pkg2appimage.

@KnowZero
Copy link
Contributor

KnowZero commented Nov 6, 2024

@daiyam That should be solvable by just setting the ENV, no?

export ARCH=x86_64

in

build/linux/appimage/build.sh

I tried it and was able to build an appimage:

https://github.com/KnowZero/vscodium/releases

@daiyam
Copy link
Member

daiyam commented Nov 6, 2024

That should be solvable by just setting the ENV, no?

Ya, surely. But I don't like this workaround.
Outside the fact that detecting a Javascript to be an armhf binary file is bogus, I really would like to be able to specify a version for pkg2appimage.

Edit: Sorry about being a bit cheeky...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants