Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix appimage build by setting ARCH env #2095

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix appimage build by setting ARCH env #2095

merged 1 commit into from
Nov 7, 2024

Conversation

KnowZero
Copy link
Contributor

@KnowZero KnowZero commented Nov 6, 2024

This patch restores the appimage builds by setting ARCH=x86_64 env to fix the building error.

Fixes #2003

@daiyam
Copy link
Member

daiyam commented Nov 6, 2024 •
edited
Loading

Thanks, I will merge the PR after the following changes:

  • can you move it before line 40
  • can you add a comment of why it's here

@KnowZero
Copy link
Contributor Author

KnowZero commented Nov 6, 2024

@daiyam done, does it look fine now?

@daiyam daiyam merged commit 45927b0 into VSCodium:master Nov 7, 2024
24 checks passed
@daiyam
Copy link
Member

daiyam commented Nov 7, 2024

The AppImage is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No appimage builds since 1.92
2 participants
@KnowZero @daiyam