Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node-v18.17 to generate all artifacts #1689

Merged
merged 5 commits into from
Oct 9, 2023
Merged

fix: use node-v18.17 to generate all artifacts #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7f60c3
wip: remove frozen-lockfile flag from yarn [skip ci]
daiyam Oct 9, 2023
326b864
ci: run checks
daiyam Oct 9, 2023
cd21627
wip: add node-gyp as direct dependency
daiyam Oct 9, 2023
2101118
wip: use node v18.17
daiyam Oct 9, 2023
5419fc2
fix: update insiders [skip ci]
daiyam Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/insider-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '18.17'

- name: Clone VSCode repo
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/insider-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '18.17'

- name: Install Yarn
run: npm install -g yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '18.17'

- name: Clone VSCode repo
run: . get_repo.sh
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/stable-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,10 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '18.17'

- name: Install Yarn
run: npm install -g yarn@latest

- name: Install lastest NPM
run: npm install -g npm@latest
run: npm install -g yarn

- name: Setup Python 3
uses: actions/setup-python@v4
Expand Down
4 changes: 2 additions & 2 deletions prepare_vscode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if [[ "${OS_NAME}" == "linux" ]]; then
fi

if [[ "${OS_NAME}" == "osx" ]]; then
CHILD_CONCURRENCY=1 yarn --frozen-lockfile --network-timeout 180000
CHILD_CONCURRENCY=1 yarn --network-timeout 180000

yarn postinstall
else
Expand Down Expand Up @@ -91,7 +91,7 @@ else
export npm_config_arm_version=7
fi

CHILD_CONCURRENCY=1 yarn --frozen-lockfile --check-files --network-timeout 180000
CHILD_CONCURRENCY=1 yarn --check-files --network-timeout 180000
fi

setpath() {
Expand Down