Splitting fixes #326
Open
Splitting fixes #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveeernight
force-pushed
the
splitting-fixes
branch
from
f724201
to
27e7ff8
Compare
MchKosticyn
reviewed
Jun 13, 2024
| // records ordered from newest to oldest | ||
| let records = PersistentDict.toSeq d |> Seq.rev // may be inefficient? | ||
| let enumerator = records.GetEnumerator() | ||
| while not foundExactKey && enumerator.MoveNext() do |
There was a problem hiding this comment.
Почему while а не for? Через for можно пробежаться по коллекции
There was a problem hiding this comment.
из for выйти нельзя
oveeernight
force-pushed
the
splitting-fixes
branch
2 times, most recently
from
7b16ec8
to
1b62ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splittingnow is used only for addresses/structs memory regionsIMemoryKey.MatchConditionis not used anymore inMemoryRegion.fs. Now we use onlyIMemoryKey.IntersectionCondition, which does not require entry region. Records inRegionTreeare ordered from oldest to newest in order of addition to the dictionary.splitReadtraverses tree from newest records to oldest ones.RegionTree.writeis used incomposeandmapinsted ofsplitWriteUpdateTreeKey.timewas removedsplitReadis terminated whenkeywhich is equal toreadKeyoccursIte-values in write operationssplitRead