Fix bug: enumerate all Windows HID devices #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindowsBackend.enumerateDevices() stops enumerating after a device fails to open. It should continue enumerating the other remaining devices. See original behavior in hidapi. https://github.com/signal11/hidapi/blob/hidapi-0.8.0-rc1/windows/hid.c#L371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for publishing purejavahidapi to Maven! It's been really helpful. I found a bug where the Windows backend wouldn't enumerate all HID devices. Please see the attached commit for a bug fix.
WindowsBackend.enumerateDevices() stops enumerating after a device fails to open. It should continue enumerating the other remaining devices. See original behavior in hidapi. https://github.com/signal11/hidapi/blob/hidapi-0.8.0-rc1/windows/hid.c#L371