feat(pdfjs): upgrade to v4 #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Hall <Jordan.Hall@mhr.co.uk>
|
What is the purpose of this? It’s a duplicate of #1105 |
|
You can read about how to contribute on GitHub or git in general. The maintainer of this project isnt very active but has merged updates / changes in the recent past, my guess is they will eventually merge 1105, who knows when. In the meantime, no one else can merge it and this PR, again, is just a duplicate that serves no purpose and should be closed. Extra 'noise'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how to update someone else's fork. So I just fork and make a new PR and hopefully it won't cause any confusing.
see discussion in #1105 . @joh-klein please review
Thank you!