Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #999: Ensure that the rotation in the viewer is not set too early #1126

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix #999: Ensure that the rotation in the viewer is not set too early #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6124eff
delay setting rotation until a least the first page is ready
ftaffelt Aug 19, 2024
ffc8f27
set transform-origin preventing overflow and unnecessary scrollbar
ftaffelt Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/pdf-viewer/pdf-viewer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
-moz-text-size-adjust: none;
text-size-adjust: none;
forced-color-adjust: none;
transform-origin: 0 0;
}

.textLayer span,
Expand Down
7 changes: 4 additions & 3 deletions src/app/pdf-viewer/pdf-viewer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,9 +541,10 @@ export class PdfViewerComponent
this._rotation !== 0 ||
this.pdfViewer.pagesRotation !== this._rotation
) {
setTimeout(() => {
this.pdfViewer.pagesRotation = this._rotation;
});
// wait until at least the first page is available.
this.pdfViewer.firstPagePromise?.then(
() => (this.pdfViewer.pagesRotation = this._rotation)
);
}

if (this._stickToPage) {
Expand Down