Rwfus v0.4.2 #35
Merged
Rwfus v0.4.2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shellcheck:
- Fixed all warnings
- Not tested extensively
Logfiles:
- Logfile location changed
- `/var/log/rwfus.log` now
- Logfile not wiped on init
This allows logfile to be continuous
TODO: improve logfile to include timestamps
- ignore rwfus.conf
It's a surprise tool that will help us later
- Actually loads config files now.
- How did I miss that?
- Actually stores config files now.
- Loaded config options are marked CF_REQUIRE
- CF_REQUIREd config options are uncommented
- This is kinda jank, but it's bash. Jank happens.
- Config file specifies which systemd units to enable, disable, and mask now
- This fixes #12
- Rwfusd now aborts and unmounts if it can't successfully mount_all
- This should hopefully make it less painful to work with in the event of a catastrophic failure.
- Preparations have begun for porting parts of the script to a better language
- I hope I can actually do that sometime. Bash is syntactic-sugar-coated hell.
Shellcheck ignore "unreachable" code in function
Shellcheck can't check dynamically named variables
Passing a single quoted string to systemctl is not what we want here
I don't want any problems here
Fail without unmounting the drive, if present. FIXME: this sucks
This (maybe?) fixes #18. Let me know if it doesn't.
We haven't supported passing Directories on the command line since 0.3.0
This implements a workaround for #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
Fixed:
polkit.serviceis automatically restarted when Rwfus goes upglibcincompatibility will break everything and ruin your day. If you need software that relies on a different version ofglibc, please update to SteamOS 3.5 and use Nix.Known Issues:
The default configuration is incompatble with SteamOS 3.5; I will be releasing another update to fix this later tonight.
Rwfus has been relatively stable on stock SteamOS for the past year, with only a few minor issues.
If you can move to Nix for package management, please do.
You can install Nix on SteamOS with Determinate Systems'
nix-installer