Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_ttl and max_ttl to the Host class and ttl to the ICMPReply class #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joente
Copy link

@joente joente commented Jun 23, 2022

The TTL properties are missing when preforming a ping (or async_ping)

Added a min_ttl and max_ttl property to the Host class which is filled from a new ttl property on the ICMPReply class.

In this version it only works for IPv4 which is enough most of the time although we could search for an implementation for IPv6 as well. (this version would return 0 for both min- and max_ttl when using an IPv6 address.

@ValentinBELYN
Copy link
Owner

Hi @joente,

Thanks for this PR. Although I find the interest of the TTL limited (there have already been several requests on this subject), I will however think about it for future versions. With icmplib, I try to have a parity between the features available between IPv4 and IPv6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants