Transform prop #149
Transform prop #149
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c54d0a:
|
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "react-easy-crop", | |||
| "version": "3.0.1", | |||
| "version": "3.1.0", | |||
There was a problem hiding this comment.
You should not update the version number in the PR. This will done on master by using np.
There was a problem hiding this comment.
I suppose it isn't a problem for this PR because the version between the local package and the dependency in docs was already different, but when working with different versions I could only get yarn to pick up the change when the version number changed. Should I also revert the lockfile change (32566a5) and then open another PR after publishing to update the docs with the new version then?
There was a problem hiding this comment.
Yes, updating the version in the doc is quite annoying but is done a manual commit after the new version is released.
The real version of the package should not be increased in PR, otherwise, it'll prevent me from publishing the new version with the default pipeline.
Co-authored-by: Valentin Hervieu <ValentinH@users.noreply.github.com>
|
This looks good to me. Would you like to open a new PR so that you are listed as the PR creator or I can merge it like this? |
I'm creating a PR just to be able to quickly test this in Codesandbox :)