Make croppedAreaPixels more accurate and rounded #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
force-pushed
the
make-croppedareapixels-more-accurate
branch
5 times, most recently
from
72a1f3b to
3b9996d
Compare
In order to make croppedAreaPixels more accurate, we now compute the width or the height (depending on the image ratio) based on the aspect property and the width/height. Also, we now round pixels values so they are integers.
ValentinH
force-pushed
the
make-croppedareapixels-more-accurate
branch
from
3b9996d to
5b811bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make croppedAreaPixels more accurate, we now compute the width
or the height (depending on the image ratio) based on the aspect property and
the width/height.
Also, we now round pixels values so they are integers.
Address #27
Demo of @raRaRa with this fix: https://codesandbox.io/s/0qk168vl10