forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(column-header-tooltip): make that hide the tooltip when the cloum… (
apache#18988) * fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated * fix(column-header-tooltip): fix lint * fix(column-header-tooltip): make to dynamic tooltip header in FilterTable * fix(column-header-tooltip): make to fix the lint issue * fix(column-header-tooltip): make to remove the tooltip option * fix(column-header-tooltip): make to add test and storybook for dynamic tooltip * fix(column-header-tooltip): make to fix lint
- Loading branch information
1 parent
def7bbb
commit 9482099
Showing
4 changed files
with
176 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
superset-frontend/src/components/TooltipParagraph/TooltipParagraph.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import TooltipParagraph from '.'; | ||
|
|
||
| export default { | ||
| title: 'DynamicTooltip', | ||
| component: TooltipParagraph, | ||
| }; | ||
|
|
||
| type IProps = { | ||
| title: string; | ||
| width: number; | ||
| }; | ||
|
|
||
| export const InteractiveTooltip = (args: IProps) => ( | ||
| <div style={{ width: `${args.width}px`, margin: '50px 100px' }}> | ||
| <TooltipParagraph>{args.title}</TooltipParagraph> | ||
| </div> | ||
| ); | ||
|
|
||
| InteractiveTooltip.story = { | ||
| parameters: { | ||
| knobs: { | ||
| disable: true, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| InteractiveTooltip.args = { | ||
| title: 'This is too long and should truncate.', | ||
| width: 200, | ||
| }; |
57 changes: 57 additions & 0 deletions
57
superset-frontend/src/components/TooltipParagraph/TooltipParagraph.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { render, screen, waitFor } from 'spec/helpers/testing-library'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import TooltipParagraph from '.'; | ||
|
|
||
| test('starts hidden with default props', () => { | ||
| render(<TooltipParagraph>This is tootlip description.</TooltipParagraph>); | ||
| expect(screen.queryByRole('tooltip')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('not render on hover when not truncated', async () => { | ||
| const { container } = render( | ||
| <div style={{ width: '200px' }}> | ||
| <TooltipParagraph> | ||
| <span data-test="test-text">This is short</span> | ||
| </TooltipParagraph> | ||
| </div>, | ||
| ); | ||
| userEvent.hover(screen.getByTestId('test-text')); | ||
| await waitFor(() => | ||
| expect(container.firstChild?.firstChild).not.toHaveClass( | ||
| 'ant-tooltip-open', | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| test('render on hover when truncated', async () => { | ||
| const { container } = render( | ||
| <div style={{ width: '200px' }}> | ||
| <TooltipParagraph> | ||
| <span data-test="test-text">This is too long and should truncate.</span> | ||
| </TooltipParagraph> | ||
| </div>, | ||
| ); | ||
| userEvent.hover(screen.getByTestId('test-text')); | ||
| await waitFor(() => | ||
| expect(container.firstChild?.firstChild).toHaveClass('ant-tooltip-open'), | ||
| ); | ||
| }); |
43 changes: 43 additions & 0 deletions
43
superset-frontend/src/components/TooltipParagraph/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React, { useState } from 'react'; | ||
| import { Tooltip, Typography } from 'antd'; | ||
| import { ParagraphProps } from 'antd/es/typography/Paragraph'; | ||
|
|
||
| const TooltipParagraph: React.FC<ParagraphProps> = ({ | ||
| children, | ||
| ellipsis, | ||
| ...props | ||
| }) => { | ||
| const [truncated, setTruncated] = useState(false); | ||
|
|
||
| return ( | ||
| <Tooltip title={truncated ? children : undefined}> | ||
| <Typography.Paragraph | ||
| {...props} | ||
| ellipsis={{ ...(ellipsis as any), onEllipsis: setTruncated }} | ||
| > | ||
| {/* NOTE: Fragment is necessary to avoid showing the title */} | ||
| <>{children}</> | ||
| </Typography.Paragraph> | ||
| </Tooltip> | ||
| ); | ||
| }; | ||
|
|
||
| export default TooltipParagraph; |