Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain error in func_tank #3303

Open
a1batross opened this issue Sep 18, 2022 · 0 comments
Open

Domain error in func_tank #3303

a1batross opened this issue Sep 18, 2022 · 0 comments

Comments

@a1batross
Copy link

When target is too close to the tank origin, d2 - r2 expression in CFuncTank::AdjustAnglesForBarrel may become negative causing domain error on square root, and poisoning other fields and even other entities with NaN.

This can be easily tested by jumping on a tank head on c2a5b. And there is even video about it: https://www.youtube.com/watch?v=VglqjKfIEZI

The proposed fix is to just don't change any angles in when target is too close: FWGS/hlsdk-portable@1394637
SamVanheer added a commit to twhl-community/halflife-updated that referenced this issue Sep 19, 2022
@SamVanheer
Fix domain errors in func_tank
90500cf 
ValveSoftware/halflife#3303
SamVanheer added a commit to twhl-community/halflife-op4-updated that referenced this issue Sep 19, 2022
@SamVanheer
Fix domain errors in func_tank_of
dde25d9 
ValveSoftware/halflife#3303
SamVanheer added a commit to twhl-community/halflife-unified-sdk that referenced this issue Sep 19, 2022
@SamVanheer
Fix domain errors in func_tank_of
78b267b 
ValveSoftware/halflife#3303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@a1batross