-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSL2 might be supported now #64
Comments
We are setting up custom runners but we still want to keep using the action, so it should be possible to configure the wsl version being used. What is worse is the the linked alternative setup-wsl2 action is not api compatible with current, basically it does not have any of the arguments supported by the current one. |
Hi 👋🏻 How do you currently use this action? Like, what options offered by this action are you currently using? When I was creating setup-wsl2, I thought of adding the options from this action, but when I read WSL documentation, the defaults seemed just right to me, so I dropped the idea and decided to implement them on request. |
No need to switch, thanks for fiddling out that and how it works in the meantime @vedantmgoyal9, I'll of course add support for WSLv2 here, now that it seems to work. |
@Vampire do you have any idea how to get environment variables from github actions? |
@vedantmgoyal9 how did you overcome
? |
You need to run this before upgrading WSL: Set-Service -Name StorSvc -StartupType Automatic |
Hm, doesn't seem to help. |
https://github.com/vedantmgoyal9/setup-wsl2/actions/runs/12119412636 |
But why should the cache cause this? |
Also hard-coding |
Yes, that was it, thanks. |
So it works without StorSvc? That's cool. When I searched for a fix for By the way, just do a |
By the way, where are you pushing the new code? I can neither see a new commit nor a new branch? 🤷🏻 |
$ git help ptm
'ptm' is aliased to '!git push origin @:refs/heads/test/master && git push origin :refs/heads/test/master' :-) |
No, not to the branch, that doesn't exist. |
Thanks, I think that is also not fully true, but just one of the things you did to cause enough time to pass before trying to install. :-D |
This time I'm sure it does hold until printing |
Who knows whether it maybe also behaves differently when running headless. 🤷♂️ |
Ok, tests are to my liking now too, and of course @ssbarnea it will be configurable with an input. |
4.0.0 has landed :-) |
See actions/runner-images#10563 and https://github.com/vedantmgoyal9/setup-wsl2.
It would be nice to have it supported by this action.
The text was updated successfully, but these errors were encountered: