Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[close #109] Use fs-local target for mounts in devices with no encryption enabled #110

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

mirkobrombin
Copy link
Member

@mirkobrombin mirkobrombin commented Aug 21, 2023

Not sure if you already changed this in your local branch or not @matbme if not, please review and squash-merge. It should be correct.

Will close #109 once merged.

@matbme
Copy link
Member

matbme commented Aug 23, 2023

This should be ready to merge but I'm starting to have doubts about the local-fs and cryptsetup targets. Yesterday, I tried changing the Systemd target to local-fs in an encrypted installation and nothing changed. systemd-analyze shows that abroot-mount was only triggered after reaching the cryptsetup target (which makes sense, since it cannot run before opening the encrypted partitions), but then I noticed my Wi-Fi settings were not saved.

I think we should merge this so we (hopefully) fix any problems with unencrypted installations but the issue doesn't seem to be fully solved yet.

@mirkobrombin
Copy link
Member Author

It's worth investigating in the beta then. Opening a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fs-local target for mounts in devices with no encryption enabled
2 participants