-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:[close #159] Systemd mount units #158
Conversation
In the future, we can create an "error" user that gets overwritten by the |
Ping #159 (for tracking purposes) |
Implementation looks good to me, but it will also require a change in vanilla-installer to use Systemd mount units. I'll work on that as soon as I can and we can then merge both PRs at the same time |
Can you make an issue for that which locks this? |
That sounds like a good idea 👍
I can probably also do the installer part. I only wanted to wait if this is even wanted, which it seems to be. |
d4eeb5f
to
77be31a
Compare
This is cleaner than using a mount script and running this as a service.
77be31a
to
2dcb531
Compare
This is now ready together with Vanilla-OS/vanilla-installer#311 |
Using systemd mount units instead of a mount script together with a systemd service has a couple of benefits:
The dependency between mounts with this implementation looks like this:
The reason we can't do this all in fstab is because you can't easily tell systemd to mount for example /home from /var/home after /var is mounted.
The question is: If we already use systemd mount units, it might be cleaner to put everything into mount units and not just the bind and overlay mounts. (The behavior would be identical since systemd just generates the mount units anyway from fstab)
Additionally, currently, the system will still try to boot even if a mount point fails, should this be changed so that systemd has to boot into recovery if a mount fails?
Also, if you want to test this, you can currently use this build: https://github.com/taukakao/ABRoot/releases/tag/systemdmount
Things that still need to be done: