-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[close #24] Add --dry-run option #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The locale changes LGTM, will lock the component on Weblate to prevent merge conficts after this PRs merge.
Needs some extra checks to avoid doing destructive operations:
I think a dry-run should enter these functions and skip the write operation. If we modify part-future, the future partition may become unusable and it's not a dry-run anymore |
move image removal after dry run
Following our discussion on Discord, I moved the image removal after the dry run and made the dry run exit earlier, skipping the init partition. For the other sections, ABRoot is writing inside .system.new, not the actual .system folder, so it is fine. |
close #24
I am unable to test due a problem with ABRoot which afflict my installation since weeks: