Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[close #184]: Implement rollback feature #185

Merged
merged 3 commits into from
Jan 5, 2024
Merged

feat[close #184]: Implement rollback feature #185

merged 3 commits into from
Jan 5, 2024

Conversation

mirkobrombin
Copy link
Member

@mirkobrombin mirkobrombin commented Jan 5, 2024 •
edited
Loading

closes #184

@mirkobrombin mirkobrombin requested a review from matbme January 5, 2024 11:21
@mirkobrombin mirkobrombin marked this pull request as draft January 5, 2024 11:22
matbme
matbme approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@matbme matbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirkobrombin mirkobrombin marked this pull request as ready for review January 5, 2024 11:32
@mirkobrombin
Copy link
Member Author

Just added responses to the rollback process, so we can inform the user if the operation was not performed due to the root being the present already.

matbme
matbme reviewed Jan 5, 2024
View reviewed changes
cmd/rollback.go Outdated Show resolved Hide resolved
@mirkobrombin @matbme
Update cmd/rollback.go
0686ab5 
Co-authored-by: Mateus Melchiades <matbme@duck.com>
@mirkobrombin mirkobrombin merged commit 0aef42a into main Jan 5, 2024
3 checks passed
@mirkobrombin mirkobrombin deleted the feat/rollback branch January 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbme matbme matbme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement rollback feature
2 participants
@mirkobrombin @matbme