cmd/pkg: Apply operation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `abroot pkg apply` operation to apply package changes based on the current image.
|
Newest images should be around 2GB now, make sure to pull the new one or reset the storage in your next test. Personally I'm fine with using the pulled one instead of the locally built, since that could already include some changes which we can remove easily since added and removed packages are stored in different files, but at cost of big layers, since adding then removing will still add bytes to the layer |
mirkobrombin
approved these changes
May 15, 2023
mirkobrombin
approved these changes
May 15, 2023
I'm pretty sure 2GB is their compressed size. They are still taking 4GB in storage on a fresh install.
|
|
makes sense |
This commit implements the new storage handling system. The apply command will now create a new ABRoot image based on the previous image, that is, without pulling a new image from the registry, and apply package changes from packages.unstaged.
|
The new container storage logic is implemented. ABRoot should now automatically remove old images and use new build images for apply operations. @mirkobrombin could you take a look again? |
mirkobrombin
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
abroot pkg applyoperation to apply package changes based on the current image.This operation assumes that the base image used to build the current root is available either locally or on the remote (which we shouldn't have to pull from but are able to if necessary). This means that we need to make sure we always keep around the current image, as well as the previous root image if it isn't the same.
Another option would be to use the image ABRoot builds when running the upgrade, but we would need to make sure that any package that was removed from
packages.addorpackages.removegets removed/reinstalled.@mirkobrombin what's your input on this? It's important to keep in mind that each image is over 4GB, so we should keep as few images as possible