Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [close #105]: Add property to decide wether to add includes per stage #129

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

axtloss
Copy link
Member

@axtloss axtloss commented Dec 19, 2024

Adds a new property addincludes which lets the user decide if a stage should include the includes.container

closes #105

@axtloss axtloss requested a review from mirkobrombin December 19, 2024 08:07
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why was this approach chosen instead of just checking if the path exists?

@axtloss
Copy link
Member Author

axtloss commented Dec 19, 2024

This is per stage, a user may want to include it during the testing stage but not the building stage, just checking if the directory exists wouldn't help

@taukakao
Copy link
Member

taukakao commented Dec 19, 2024

I see, interesting. But yeah, makes sense to me.

@axtloss axtloss merged commit 45896f2 into main Dec 20, 2024
3 checks passed
@axtloss axtloss deleted the feat/optional-includes branch December 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add property to decide if a stage should get sources and/or includes added
3 participants