Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source for single file #60

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

deepu9
Copy link
Contributor

@deepu9 deepu9 commented Jul 4, 2024

Closes #18

  1. Added ability to download a file from an url.
  2. Also, run the checksum validation on the file and
  3. Finally move the downloaded file to a source folder.

@deepu9 deepu9 marked this pull request as ready for review July 4, 2024 02:55
@kbdharun kbdharun changed the title feat/18 Add source for single file feat: add source for single file Jul 7, 2024
@kbdharun kbdharun requested a review from mirkobrombin July 8, 2024 06:06
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbdharun kbdharun self-assigned this Jul 10, 2024
deepu9 and others added 2 commits July 10, 2024 14:21
Added a function to download the file and move the file to source folder
under build.
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun force-pushed the feat/18-add-source-for-single-file branch from 8633c0e to c01b2a6 Compare July 10, 2024 09:34
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Tested the changes locally and made a few improvements:

  1. Improved Error handling for checksum in the source types.
  2. Updated docs to reflect the changes.
  3. Updated Gitignore file to not commit Vib generated/config files to the repository.
  4. Update website's index example (unrelated to PR).

Recipe used for testing:

name: Testing recipe
id: test
stages:
  - id: build
    base: ghcr.io/vanilla-os/pico:main
    singlelayer: false
    labels:
      maintainer: Vanilla OS Contributors
    modules:
      - name: build-app
        type: shell
        source:
          type: file
          url: https://github.com/Vanilla-OS/Vib/releases/download/v0.7.3/vib
          checksum: 5c4dbe2bef7c23175ad1c8230840a6b3c91c3ab3ed1eb026d9bc4b6eb382333d
        commands:
          - ./vib -v 

@kbdharun kbdharun merged commit 7cf30ad into Vanilla-OS:main Jul 10, 2024
2 checks passed
@deepu9
Copy link
Contributor Author

deepu9 commented Jul 10, 2024

LGTM, thanks for your contribution.

Tested the changes locally and made a few improvements:

  1. Improved Error handling for checksum in the source types.
  2. Updated docs to reflect the changes.
  3. Updated Gitignore file to not commit Vib generated/config files to the repository.
  4. Update website's index example (unrelated to PR).

Recipe used for testing:

name: Testing recipe
id: test
stages:
  - id: build
    base: ghcr.io/vanilla-os/pico:main
    singlelayer: false
    labels:
      maintainer: Vanilla OS Contributors
    modules:
      - name: build-app
        type: shell
        source:
          type: file
          url: https://github.com/Vanilla-OS/Vib/releases/download/v0.7.3/vib
          checksum: 5c4dbe2bef7c23175ad1c8230840a6b3c91c3ab3ed1eb026d9bc4b6eb382333d
        commands:
          - ./vib -v 

Thanks @kbdharun. My apologies for not updating the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api: Add Source for single file
3 participants