-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add source for single file #60
feat: add source for single file #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a function to download the file and move the file to source folder under build.
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
8633c0e
to
c01b2a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
Tested the changes locally and made a few improvements:
- Improved Error handling for checksum in the source types.
- Updated docs to reflect the changes.
- Updated Gitignore file to not commit Vib generated/config files to the repository.
- Update website's index example (unrelated to PR).
Recipe used for testing:
name: Testing recipe
id: test
stages:
- id: build
base: ghcr.io/vanilla-os/pico:main
singlelayer: false
labels:
maintainer: Vanilla OS Contributors
modules:
- name: build-app
type: shell
source:
type: file
url: https://github.com/Vanilla-OS/Vib/releases/download/v0.7.3/vib
checksum: 5c4dbe2bef7c23175ad1c8230840a6b3c91c3ab3ed1eb026d9bc4b6eb382333d
commands:
- ./vib -v
Thanks @kbdharun. My apologies for not updating the docs. |
Closes #18