-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy add alignment #63
Conversation
I feel we need to bump the version of Vib to reflect the new overall structure including the previously merged workdir changes. Please let me know what you think. Thank you! |
While I preferred the syntax of copy over that of add I think it's too late to change this now either way. And yes, I agree that this should be a new vib version. |
Hello Tau.
I went with the ADD syntax because it is simpler (less typing) and behaves more like an actual Dockerfile. What really matters in the end is consistency. |
It's just my personal opinion. I guess we can wait if other people have an opinion as well. |
a702cf9
to
5eba5fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5eba5fa
to
69e044f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution. Tested and verified the changes locally.
Adjust
COPY
instruction to be in line withADD
instructionDescription
This PR adjusts the
COPY
command structure to be in line with the similarADD
command. This ensures consistency and closely emulates how raw Dockerfiles work.Proposed Changes
Copy
structure to use a map to specify source and destinationPath
structureExample
Before
After
Local Testing
Using the following
vib.yml
recipe:Generated Containerfile: