-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:[close #183] Restrict differ to dev branch only #207
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Afaik, the main branch is no longer going to be used and instead dev branch will be tagged and released (which will automatically push to the main tag too).
Need confirmation from @taukakao on this.
That is likely correct. The release is tagged as |
Add branches definition to differ workflow Change container ref to match branch name
cf64bc7
to
2b756e1
Compare
I impatiently updated the PR. It now targets dev and no longer hard codes the tag |
Nice, however, the issue with the current implementation is stable users use the desktop-image/.github/workflows/vib-build.yml Lines 84 to 87 in 1cfa836
So if differ is run and generates a changelog for specific tags, the end users might not get the changelog since it would be uploaded to the differ instance for the tag instead of the main one. |
i think im missing some info, but if i understand correctly:
does that track? Edit: oh I see my branch is behind |
Tested here on commit
0e4c7ce
closes #183