Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable smartcard authentication on gdm3 #209

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

lucas-stauder
Copy link

@lucas-stauder lucas-stauder commented Sep 15, 2024

Disables smartcard authentication in gdm3 by default which is an issue for users with yubikeys or similar smartcards.

The feature is only useful for corporate networks, which Vanilla OS isn't targeting currently and which would create unique images either way

https://gitlab.gnome.org/GNOME/gdm/-/issues/877

@lucas-stauder
Copy link
Author

@axtloss
Copy link
Member

axtloss commented Sep 15, 2024

is there no conf.d directory for gdm where things like these can be put in their own files? that'd be a lot more reliable than editing the main config directly

@lucas-stauder
Copy link
Author

is there no conf.d directory for gdm where things like these can be put in their own files? that'd be a lot more reliable than editing the main config directly

fixed, thanks for the idea!

Copy link
Member

@axtloss axtloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits so that i can merge them

@lucas-stauder
Copy link
Author

Please squash your commits so that i can merge them

Done!

@axtloss axtloss merged commit 8aa1684 into Vanilla-OS:dev Sep 15, 2024
3 checks passed
@lucas-stauder
Copy link
Author

It's not working with the Config file in the directory, I had the other line still in the main config file while testing by accident ... Either the folder is wrong or it has no support for folder based configuration

@mirkobrombin
Copy link
Member

We should rollback the changes or fix them then

@axtloss
Copy link
Member

axtloss commented Sep 16, 2024

According to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051785#52 the proper file is /etc/gdm3/greeter.dconf-defaults and a config directory doesn't exist, so i guess we'll just use that file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants