Remove deprecated method which causing gcc10 warnings #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linev
changed the title
Axel-Naumann
reviewed
Jun 9, 2020
Comment on lines
+213
to
+219
| // template <typename V2> | ||
| // Vc_DEPRECATED("use reinterpret_components_cast instead") Vc_ALWAYS_INLINE V2 | ||
| // reinterpretCast() const | ||
| // { | ||
| // typedef typename V2::EntryType AliasT2 Vc_MAY_ALIAS; | ||
| // return V2(*reinterpret_cast<const AliasT2 *>(&m_data)); | ||
| // } |
There was a problem hiding this comment.
Why not just remove these lines?
There was a problem hiding this comment.
To keep sign - something was there but just disabled
Axel-Naumann
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
In root-project/root#5833 @amadio argued for removing only the deprecation message, while @linev suggests to remove the whole function signature. Given that the interface is deprecated since 5 years I think we should remove it. I bet Matthias deprecated it for a reason. I am OK with commenting it to leave a trace of the function's removal.
Given all this, I believe this PR should get merged.
|
@Axel-Naumann, should we merge it? I cannot do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #253