Allow consumption in subprojects #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Vc as a subproject of another CMake project, either by including it as a git submodule or by using CMake's FetchContent, the CMAKE_SOURCE_DIR variable does not point to the repository root. Similary, the CMAKE_BINARY_DIR does no longer correspond to the CMAKE_CURRENT_BINARY_DIR of the the top-level CMakeLists.txt file. Using PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR instead guarantees that additional files (e.g. the CMake Config template or custom modules) are found correctly and that no files of the consuming project in the CMAKE_BINARY_DIR are overwritten.
When including Vc as a subproject of another CMake project (e.g. via FetchContent or git submodules) it might not be necessary to not install Vc alongside the consuming project. To allow consumers to decide whether they want to install Vc or not this commit adds a new option Vc_ENABLE_INSTALL that is ON by default.
bernhardmgruber
approved these changes
Jun 22, 2021
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to use git submodules and
add_subfolderorFetchContentin a consuming CMake project to build Vc as part of the build of the consumer. This PR fixes the build issues and also adds an option to disable the installation, which is desirable when the consuming project is an application that links statically against Vc. Without that option the Vc headers and binaries are installed alongside the application even though they aren't needed.