-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp: adjust boundaries for single-precision floating point #295
Conversation
Hi again! Thank you for the great work! I will ask my colleague @amadio to review this, since he is also working on Geant4, to which you referred in the linked issue. This might take a few weeks though, since he is currently on vacation. You might try to play with the CI for now to get it compiling. Thank you again! |
I think the change is ok, but the commit needs to be fixed before merging, as there's a comment terminator inside the comment that needs to be removed. |
9083bb8
to
408cbd5
Compare
I'm getting CI failures but I can't seem to find the actual error. |
You can see the errors on CDash: http://cdash.cern.ch/index.php?project=Vc&date=2021-08-12, though I also only see warnings there for your builds (check with short commit hash 408...). |
@amyspark please rebase on 1.4 to get the CI working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would like @amadio's feedback as well though.
👋
In this MR, I adjust the boundaries of
exp
to account for the precision allowed byfloat
.I've used the following snippet of code to determine the exact values. These are, in each case, the last value of
boundary
.Open for snippet
Please let me know if I can improve it!
Fixes #273