Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt: use CMAKE_CURRENT_LIST_DIR for module path #302

Merged
merged 1 commit into from
Apr 8, 2022
Merged

CMakeLists.txt: use CMAKE_CURRENT_LIST_DIR for module path #302

merged 1 commit into from
Apr 8, 2022

Conversation

htfy96
Copy link
Contributor

@htfy96 htfy96 commented Oct 3, 2021

Fix #301

@bernhardmgruber bernhardmgruber added this to the Vc 1.4.3 milestone Oct 4, 2021
@bernhardmgruber
Copy link
Collaborator

Hi! Thank you for your contribution! There are 4 places using CMAKE_CURRENT_SOURCE_DIR in the main CMakeLists.txt and the VcMacros.cmake file. I would be surprised if you do not need to change all 4 of them. Could you please also change the other instances?
Using CMAKE_CURRENT_SOURCE_DIR in the examples and tests is probably fine, since you don't care about them when using Vc as a submodule.

@amadio
Copy link
Collaborator

amadio commented Apr 8, 2022

I had a quick look, and I think the remaining places can actually stay as CMAKE_CURRENT_SOURCE_DIR. We can merge this.

@amadio amadio merged commit 45fbb88 into VcDevel:1.4 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Vc 1.4.3
Development

Successfully merging this pull request may close these issues.

Use CMAKE_CURRENT_LIST_DIR instead of CMAKE_CURRENT_SOURCE_DIR in CMakeLists.txt
3 participants
@htfy96 @bernhardmgruber @amadio