Fix zen3 flags for icc and support icelake #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might not work yet, because the Vc static library for AVX2 compiles with |
bernhardmgruber
force-pushed
the
zen3fix
branch
from
94239ba to
cc93142
Compare
bernhardmgruber
changed the title
Closed
bernhardmgruber
force-pushed
the
zen3fix
branch
2 times, most recently
from
15e8240 to
690481f
Compare
bernhardmgruber
force-pushed
the
zen3fix
branch
from
690481f to
02c27b6
Compare
bernhardmgruber
force-pushed
the
zen3fix
branch
from
02c27b6 to
e491eda
Compare
amadio
reviewed
Mar 24, 2022
| @@ -495,7 +495,7 @@ macro(vc_compile_for_all_implementations _srcs _src) | |||
| # which case AVX2 implies the availability of FMA and BMI2 | |||
| #_vc_compile_one_implementation(${_srcs} AVX2 "-mavx2") | |||
| #_vc_compile_one_implementation(${_srcs} AVX2+BMI2 "-mavx2 -mbmi2") | |||
| _vc_compile_one_implementation(${_srcs} AVX2+FMA+BMI2 "-xCORE-AVX2" "-mavx2 -mfma -mbmi2" "/arch:AVX2") | |||
| _vc_compile_one_implementation(${_srcs} AVX2+FMA+BMI2 "-xAVX2" "-mavx2 -mfma -mbmi2" "/arch:AVX2") | |||
There was a problem hiding this comment.
Yes. And funnily it works. Because the unit tests did not work with -xAVX2, I needed -mavx2. Should we change to -mavx2 here as well?
There was a problem hiding this comment.
Yes, I think that anything that could be run on AMD should fallback to -mavx2 so that the compiler doesn't add special code based on cpuid checks (for example, if may just fallback to scalar if the AMD CPU is not recognized, or even intentionally).
There was a problem hiding this comment.
I will send a separate PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the flags passed to icc, when a zen3 CPU was detected. It furthermore let's icc build the AVX2 Vc static library without Intel specific instruction sets. To make the CI pass, also support for icelake CPUs had to be cherry-picked from #319.