Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELF_STT_FUNC address not taking into account rebasing #5685

Closed
xusheng6 opened this issue Jul 4, 2024 · 0 comments
Closed

ELF_STT_FUNC address not taking into account rebasing #5685

xusheng6 opened this issue Jul 4, 2024 · 0 comments
Labels
Component: BinaryViewType Effort: Trivial Issue should take < 1 day File Format: ELF Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Milestone
Elysium

Comments

@xusheng6
Copy link
Member

xusheng6 commented Jul 4, 2024 •
edited
Loading

For functions that get defined via ELF_STT_FUNC, we are not processing its start address with the actual image base. This causes a lot of [Analysis] Attempting to add function not backed by file: 0xXXXX when we rebase the file

binaryninja-api/view/elf/elfview.cpp

Line 1156 in 1ffd063

Ref<Function> func = AddFunctionForAnalysis(targetPlatform, entry.value);

Binary https://github.com/Vector35/binaryninja-api/files/12284520/libhdk-mips-elf.zip (same one as in #4556)
xusheng6 added a commit that referenced this issue Jul 5, 2024
@xusheng6
Account for rebasing when processing ELF_STT_FUNC entries. Fix #5685
8bf542a
@xusheng6 xusheng6 added Type: Bug Issue is a non-crashing bug with repro steps File Format: ELF Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day Component: BinaryViewType labels Jul 8, 2024
@xusheng6 xusheng6 added this to the Elysium milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: BinaryViewType Effort: Trivial Issue should take < 1 day File Format: ELF Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Milestone
Elysium
Development

No branches or pull requests
1 participant
@xusheng6