Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to the README.md and CONTRIBUTING.md files #4

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Feb 8, 2024

PR Type

Documentation

Short Description

Clickup Ticket(s): https://app.clickup.com/t/86877aha9

Adding information about building and running the project into readme and contributing files.

Tests Added

NA

@lotif
Copy link
Collaborator Author

lotif commented Feb 8, 2024

@jewelltaylor I've added some information about building and running what we have so far in the #3 PR. Let me know if there is more stuff you'd like to see there.

README.md Show resolved Hide resolved
## Development dependencies

To install development dependencies, first you need to create a virtual environment.
The easiest way is by using the [virtualenv](https://pypi.org/project/virtualenv/) package:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly mention we expect python between 3.9 and 3.11? Or it is it enough to have it in the pyproject.toml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having it in pyproject.toml is enough, we don't have a hard requirement on it ourselves. Besides, when we change it, it's gonna be one less thing for us to worry about.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I was able to get the front end client and back end api up and running locally with these instructions, so LGTM!

@lotif lotif merged commit e06b4e9 into main Feb 15, 2024
1 check passed
@lotif lotif deleted the readme-contrib-info branch February 15, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants