Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression metrics #547

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Add regression metrics #547

merged 3 commits into from
Jan 16, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Jan 16, 2024

PR Type

Feature.

Short Description

Add regression metrics - mean absolute error, mean squared error, mean absolute percentage error, symmetric mean absolute percentage error, weighted mean absolute error

Tests Added

tests/cyclops/evaluate/metrics/experimental/test_mean_error.py

@fcogidi fcogidi added the enhancement New feature or request label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (df4739d) 70.02% compared to head (a543850) 70.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   70.02%   70.50%   +0.47%     
==========================================
  Files         114      124      +10     
  Lines       10916    11106     +190     
==========================================
+ Hits         7644     7830     +186     
- Misses       3272     3276       +4     
Files Coverage Δ
...ps/evaluate/metrics/experimental/functional/mae.py 100.00% <100.00%> (ø)
...s/evaluate/metrics/experimental/functional/mape.py 100.00% <100.00%> (ø)
...ps/evaluate/metrics/experimental/functional/mse.py 100.00% <100.00%> (ø)
.../evaluate/metrics/experimental/functional/smape.py 100.00% <100.00%> (ø)
.../evaluate/metrics/experimental/functional/wmape.py 100.00% <100.00%> (ø)
cyclops/evaluate/metrics/experimental/mae.py 100.00% <100.00%> (ø)
cyclops/evaluate/metrics/experimental/mape.py 94.44% <94.44%> (ø)
cyclops/evaluate/metrics/experimental/smape.py 94.44% <94.44%> (ø)
cyclops/evaluate/metrics/experimental/wmape.py 95.23% <95.23%> (ø)
cyclops/evaluate/metrics/experimental/mse.py 90.47% <90.47%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

@fcogidi fcogidi merged commit 5c4ebb2 into main Jan 16, 2024
9 checks passed
@fcogidi fcogidi deleted the add_regression_metrics branch January 16, 2024 14:19
rjavadi pushed a commit that referenced this pull request Jan 30, 2024
* Add regression support

* update docstrings

* Ignore `no-any-return` errors
amrit110 added a commit that referenced this pull request Feb 11, 2024
* Changed documentation theme to sphinx-book-theme

* Added details about Pandoc requirment

* Added initial document for accuracy.py

* Fix pre-commit hook errors

* Added confusion matrix doc

* Add auroc doc and fix titles

* Add average precision docs

* Added more documents for metrics

* Add index for user guide in side bar

* Minor patches (#542)

* Fix capitalization of Python

* Change ValueError to TypeError and update docstrings

* Add Precision-Recall Curve to experimental metrics (#544)

* Add ROC curve (#545)

* Add ROC metrics to experimental module

* fix typo

* Fix docstrings

* Add AUROC (#546)

* Add AUROC metric to experimental module

* Refactor binary and multiclass ROC functions

* Refactor tests to use a common thresholds list

* Fix mypy error

* Add regression metrics (#547)

* Add regression support

* update docstrings

* Ignore `no-any-return` errors

* Integrate experimental metrics with other modules (#549)

* integrate experimental metrics with other modules

* add average precision metric to experimental metrics package

* fix tutorials

* Add type hints and keyword arguments to metrics classes

* Update nbsphinx version to 0.9.3

* Update nbconvert version to 7.14.2

* Fix type annotations and formatting issues

* Update kernel display name in mortality_prediction.ipynb

* Add guard clause to prevent module execution on import

* Update `torch_distributed.py` with type hints

* Add multiclass and multilabel average precision metrics

* Change jupyter kernel

* Fix type annotations for metric values in ClassificationPlotter

---------

Co-authored-by: Amrit K <amritk@vectorinstitute.ai>

* Changed documentation theme to sphinx-book-theme

* Don't update deps

* Pre-commit fixes

* Add doc for ROC Curve

* Fix footer in docs

* Bump to 0.2.3

Signed-off-by: Amrit Krishnan <amrit110@gmail.com>

* Add logo and css fixes

* Fix formatting of conf.py file

* Small fix

* Move evaluation metrics docs under API reference

* Fix poetry build

* Improve documentation structure

* Formatting fixes

---------

Signed-off-by: Amrit Krishnan <amrit110@gmail.com>
Co-authored-by: Franklin <41602287+fcogidi@users.noreply.github.com>
Co-authored-by: Amrit K <amritk@vectorinstitute.ai>
Co-authored-by: Amrit Krishnan <amrit110@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant