Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at refactoring jinja template #567

Merged
merged 1 commit into from
Feb 28, 2024
Merged

First pass at refactoring jinja template #567

merged 1 commit into from
Feb 28, 2024

Conversation

amrit110
Copy link
Member

PR Type ([Feature | Fix | Documentation | Test])

Refactor

Short Description

  • Move JS code from template into separate files
  • Apply eslint to fix some styling issues
  • Move template to new model_report folder, so that new templates can be added in the future in directories

Tests Added

...

@amrit110 amrit110 requested a review from a-kore February 28, 2024 20:05
@amrit110 amrit110 self-assigned this Feb 28, 2024
@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Feb 28, 2024
@amrit110 amrit110 merged commit 9936852 into main Feb 28, 2024
6 checks passed
@amrit110 amrit110 deleted the refactor_jinja_template branch February 28, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-kore a-kore a-kore approved these changes

Assignees

@amrit110 amrit110

Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrit110 @a-kore