Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #581

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix typos #581

merged 2 commits into from
Mar 12, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Mar 12, 2024

PR Type

Fix.

Short Description

Ran typos through the repo.

Tests Added

...

@fcogidi fcogidi added documentation Improvements or additions to documentation refactor Refactor existing code, with same or similar functionality labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (f8e790f) to head (95e6ac1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files         128      128           
  Lines       11361    11361           
=======================================
  Hits         8359     8359           
  Misses       3002     3002           
Files Coverage Δ
cyclops/data/aggregate.py 77.37% <ø> (ø)
cyclops/data/clean.py 95.55% <ø> (ø)
cyclops/data/df/feature.py 72.37% <100.00%> (ø)
cyclops/data/df/normalize.py 86.98% <ø> (ø)
cyclops/data/df/split.py 98.87% <100.00%> (ø)
cyclops/data/impute.py 80.39% <ø> (ø)
...etrics/experimental/distributed_backends/mpi4py.py 36.73% <ø> (ø)
...rimental/distributed_backends/torch_distributed.py 32.72% <ø> (ø)
cyclops/evaluate/metrics/experimental/roc.py 100.00% <ø> (ø)
cyclops/evaluate/metrics/experimental/utils/ops.py 86.24% <100.00%> (ø)
... and 11 more

Impacted file tree graph

@amrit110
Copy link
Member

@fcogidi seems to have caught a lot of typos! i think the benefit of this outweighs the cases where it might fail. i think its worth adding to the template.

@fcogidi
Copy link
Collaborator Author

fcogidi commented Mar 12, 2024

@fcogidi seems to have caught a lot of typos! i think the benefit of this outweighs the cases where it might fail. i think its worth adding to the template.

Thanks for fixing the notebook issues!

I didn't add typos to the pre-commit hooks yet because it requires configuration of many words to ignore.

@amrit110
Copy link
Member

@fcogidi , ok then for now lets not add it to the pre-commit hooks here. perhaps it can be run once in a while to find typos in the codebase.

@amrit110 amrit110 self-requested a review March 12, 2024 13:32
@amrit110 amrit110 merged commit ca6a9d8 into main Mar 12, 2024
10 checks passed
@amrit110 amrit110 deleted the fix_typos branch March 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants