Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleAuthenticator.php #5

Closed
wants to merge 1 commit into from

Conversation

DaveAmity
Copy link

@DaveAmity DaveAmity commented Jan 30, 2024

Added the title and name functionality for most Authenticator apps.

Example Usage:

        $email_user= 'johndoe@test.com';
        $title= 'Name of the app';
        $secret = $ga->createSecret();
        $qrCodeUrl = $ga->getQRCodeUrl($email_user, $secret, $title);

Output after scanning in Authenticator App :

Screenshot_20240130_151025_Authenticator

Added the title and name functionality for most Authenticator apps.
@jdpanderson
Copy link
Member

I was a bit concerned that the third parameter semi-conflicts with the first param in that any existing users might be using the name param as both a combined label & issuer. (We actually do that in our internal code! 😆)

I also took the opportunity to correct some naming, and expose more of the otpauth URI scheme parameters in #6. It should be able to handle your requirements as well.

@jdpanderson
Copy link
Member

jdpanderson commented Jan 31, 2024

Thanks for submitting the PR. We wouldn't have noticed the missing feature without it. Cheers!

Closing in favor of #6 (merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants